dsmiley commented on code in PR #3947:
URL: https://github.com/apache/solr/pull/3947#discussion_r2651526676
##########
solr/test-framework/src/java/org/apache/solr/util/SolrClientTestRule.java:
##########
@@ -68,7 +68,7 @@ public NewCollectionBuilder(String name) {
this.name = name;
}
- public NewCollectionBuilder withConfigSet(String configSet) {
+ public NewCollectionBuilder withConfigSet(Path configSet) {
Review Comment:
I appreciate this change, but I feel this should be overloaded so a
configSet can be referenced by name instead of path. For that, we can just
trivially set the field (one liner).
##########
solr/core/src/test/org/apache/solr/handler/TestStressIncrementalBackup.java:
##########
@@ -52,8 +52,7 @@ public void beforeTest() throws Exception {
backupPath = createTempDir(getTestClass().getSimpleName() + "_backups");
System.setProperty("solr.security.allow.paths", backupPath.toString());
- // NOTE: we don't actually care about using SolrCloud, but we want to use
SolrClient and I can't
- // bring myself to deal with the nonsense that is SolrJettyTestBase.
+ // NOTE: we don't actually care about using SolrCloud, but we want to use
SolrClient.
Review Comment:
LOL. Maybe this becomes a TODO now that we have a nice rule encapsulating
Solr lifecycle for Jetty
CC @gerlowskija
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
