janhoy commented on code in PR #3983:
URL: https://github.com/apache/solr/pull/3983#discussion_r2649324237
##########
solr/bin/solr:
##########
@@ -1283,8 +1170,8 @@ function start_solr() {
# need to launch solr from the server dir
cd "$SOLR_SERVER_DIR" || (echo -e "\nCd to SOLR_SERVER_DIR failed" && exit 1)
- if [ ! -e "$SOLR_SERVER_DIR/start.jar" ]; then
- echo -e "\nERROR: start.jar file not found in $SOLR_SERVER_DIR!\nPlease
check your --server-dir parameter to set the correct Solr server directory.\n"
+ if [ ! -e "$SOLR_SERVER_DIR/solr-start.jar" ]; then
Review Comment:
Yep, the original SIP text proposes `solr.jar` here. But I got the idea that
if we use `solr-start.jar`, it will still match a grep for `start.jar` when
listing processes :) Really, since the module name is `bootstrap` it will
probably be called `solr-bootstrap-11.0.0.jar` in maven. It's just a name,
noone will call it manually except those who write their own daemon wrappers or
something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
