janhoy commented on code in PR #3983:
URL: https://github.com/apache/solr/pull/3983#discussion_r2649323012
##########
solr/bin/solr:
##########
@@ -1210,12 +1101,8 @@ function start_solr() {
fi
- # If SSL-related system props are set, add them to SCRIPT_SOLR_OPTS
- if [ "$SOLR_SSL_ENABLED" == "true" ]; then
- # If using SSL and solr.jetty.https.port not set explicitly, use the
solr.port.listen
- SSL_PORT_PROP="-Dsolr.jetty.https.port=$SOLR_PORT_LISTEN"
- SCRIPT_SOLR_OPTS+=($SOLR_SSL_OPTS "$SSL_PORT_PROP")
- fi
+ # SIP-6: SSL configuration is now handled by ServerConfiguration and
ConnectorFactory in Java
+ # No need to pass SSL properties explicitly - they're read from environment
variables
Review Comment:
Sure, this is just POC filler.
If we go this direction, it will open up for porting most of the start
script to Java, except the JVM level props like heap, gc etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
