dsmiley commented on PR #3829: URL: https://github.com/apache/solr/pull/3829#issuecomment-3693687954
I did a series of things, as seen in a series of commits: 1. HttpApacheSolrClient no longer extends HttpSolrClient in this PR. Unfortunate but it'll interfere... 2. Rename HttpSolrClientBase to HttpSolrClient. (replacing my earlier simply attempt at an abstract HttpSolrClient in this PR) 3. Rename HttpSolrClientBuilderBase.java to HttpSolrClient.BuilderBase (inner class, now) 4. Renamed HttpSolrClient.builder() internal instance method to `toBuilder(url)` to not conflict with... 5. Added HttpSolrClient.builder(url) static method, mostly using code moved from CloudSolrClient, which now uses this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
