gerlowskija commented on code in PR #3829:
URL: https://github.com/apache/solr/pull/3829#discussion_r2499543142
##########
solr/test-framework/src/java/org/apache/solr/client/solrj/apache/SolrPortAwareCookieSpecFactory.java:
##########
@@ -31,6 +31,7 @@
import org.apache.http.protocol.HttpContext;
@SuppressWarnings("deprecation")
+@Deprecated
Review Comment:
[Q] Why is this deprecated in this PR? Is it just a part of the larger
"apache client" deprecation that was missed until now?
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##########
@@ -548,7 +548,7 @@ public void testUpdate() throws Exception {
assertEquals("post", DebugServlet.lastMethod);
assertEquals(
- "Solr[" + HttpSolrClient.class.getName() + "] " + UA_VERSION,
+ "Solr[" + HttpApacheSolrClient.class.getName() + "] " + UA_VERSION,
Review Comment:
[0] Holy duplication. I understand that we shouldn't delve into refactors
or unrelated cleanups in this PR, but what a shame this test doesn't use a
constant or something here.
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/BasicHttpSolrClientTest.java:
##########
Review Comment:
[Q] Should this test class itself be renamed, as it seems like it's specific
to the "Apache" version of the client?
##########
solr/solrj/src/java/org/apache/solr/client/solrj/HttpSolrClient.java:
##########
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.solr.client.solrj;
+
+/** A {@link SolrClient} based on HTTP. */
Review Comment:
[Q] I can imagine folks familiar with the old concrete implementation
"HttpSolrClient" coming here, finding it's now abstract, and not being sure
which implementation they should actually use.
Wdyt about adding a few `@see` tags here pointing at the different
implementations, or alternatively a sentence or two to the effect of: "If
you're looking for a single-url client to actually use, go check out..."
##########
changelog/unreleased/SOLR-17968-HttpSolrClient.yml:
##########
@@ -0,0 +1,8 @@
+
+title: Introduce org.apache.solr.client.solrj.HttpSolrClient, implemented by
the Jetty & JDK HttpClient based SolrClients.
Review Comment:
[Q] Is it worth mentioning the Apache SolrClient here as well? I know it's
deprecated, but the conspicuous absence might imply to folks that
HttpApacheSolrClient *doesn't* inherit from HttpSolrClient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
