dsmiley commented on code in PR #3909:
URL: https://github.com/apache/solr/pull/3909#discussion_r2575191031
##########
solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java:
##########
@@ -181,13 +181,8 @@ public SolrIndexConfig(ConfigNode cfg, SolrIndexConfig
def) {
}
if (get("infoStream").boolVal(false)) {
- if (get("infoStream").attr("file") == null) {
- log.info("IndexWriter infoStream solr logging is enabled");
- infoStream = new LoggingInfoStream();
- } else {
- throw new IllegalArgumentException(
- "Remove @file from <infoStream> to output messages to solr's
logfile");
- }
+ log.info("IndexWriter infoStream solr logging is enabled");
Review Comment:
Ah, astute observation. I still don't like it; I would rather have seen a
general way to customize logging per configset (e.g. a log4j2.xml in the
configset) rather than an obscure setting specifically just for this that's
"trappy" because you need to also configure log4j right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
