dsmiley commented on code in PR #3909:
URL: https://github.com/apache/solr/pull/3909#discussion_r2574973626
##########
solr/server/solr/configsets/_default/conf/solrconfig.xml:
##########
@@ -199,7 +199,7 @@
Setting The value to true will instruct the underlying Lucene
IndexWriter to write its debugging info the specified file
-->
- <!-- <infoStream file="INFOSTREAM.txt">false</infoStream> -->
+ <infoStream>false</infoStream>
Review Comment:
I see above for other things that we comment out the defaults rather than
literally put them here. I think the general trend should be to *not* have
configuration for defaults -- embracing good defaults.
##########
solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java:
##########
@@ -181,13 +181,8 @@ public SolrIndexConfig(ConfigNode cfg, SolrIndexConfig
def) {
}
if (get("infoStream").boolVal(false)) {
- if (get("infoStream").attr("file") == null) {
- log.info("IndexWriter infoStream solr logging is enabled");
- infoStream = new LoggingInfoStream();
- } else {
- throw new IllegalArgumentException(
- "Remove @file from <infoStream> to output messages to solr's
logfile");
- }
+ log.info("IndexWriter infoStream solr logging is enabled");
Review Comment:
Why say this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
