[
https://issues.apache.org/jira/browse/SOLR-17161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18038765#comment-18038765
]
David Smiley commented on SOLR-17161:
-------------------------------------
Thanks for your review!
LBHttp2SolrClient is going to be renamed to LBAsyncSolrClient since that is its
value-add on top of LBSolrClient. And made abstract with LBJettySolrClient as
the only impl (no JDK yet). Meanwhile, LBSolrClient has been improved a little
to allow its use with JDK or Jetty clients in a straight-forward way.
The advantage of implementations with "Jetty" or "JDK" in the name is that
there's no mystery as to what you're getting. It also side-steps the dubious
historical naming choice of "Http2". And given some of the twists and turns
since Solr ~8... we'd arrive at clarity, not further ambiguity. There's
something to be said for that. I'm not sure we should be opinionated,
insisting on one approach, or keep both. The PR currently keeps both. I lean
to allow both. I intentionally provided both for discussion/review.
Perhaps {{new CloudSolrClient.Builder}} should point to the code of
{{CloudHttp2SolrClient}} so that a user doesn't see "Http2"? And/or rename
{{CloudHttp2SolrClient}} to something.
> Separate out a solrj-jetty artifact (10.0)
> ------------------------------------------
>
> Key: SOLR-17161
> URL: https://issues.apache.org/jira/browse/SOLR-17161
> Project: Solr
> Issue Type: Sub-task
> Components: clients - java
> Reporter: Jan Høydahl
> Assignee: David Smiley
> Priority: Blocker
> Labels: pull-request-available
> Fix For: 10.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Given we have a native JDK based client in SOLR-599, we can separate out all
> {{Http2SolrClient}} and freiends with their jetty-client dependencies into a
> separate artifact {{{}solrj-jetty{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
