jdyer1 commented on code in PR #3852:
URL: https://github.com/apache/solr/pull/3852#discussion_r2510788530
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClientBase.java:
##########
@@ -340,6 +347,14 @@ protected void setParser(ResponseParser parser) {
protected abstract void updateDefaultMimeTypeForParser();
+ /** Experimental; subject to change! */
+ @Deprecated // for internal use; expected to change soon
+ public abstract NamedList<Object> requestWithBaseUrlNl(
Review Comment:
In `HttpJdkSolrClient` all 3 methods, `request`, `requestAsync` and
`requestWithBaseUrl` take a request and collection and return a `NamedList`.
This seems like a sensible api. Yet `Http2SolrClient` has
`requestWithBaseUrl` with a different signature. I am not sure what your
intention here is, but it seems to me the api used by the jdk client would make
the most sense to users. (Side point here, but the current behavior of
`Http2SolClient#requestWthBaseUrl` where it basically clones itself on each
request seems rather unfortunate.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
