dsmiley commented on code in PR #3648: URL: https://github.com/apache/solr/pull/3648#discussion_r2488089815
########## solr/core/src/java/org/apache/solr/handler/component/CompoundResponseBuilder.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.component; + +import java.util.ArrayList; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import org.apache.solr.common.params.FacetParams; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; + +public class CompoundResponseBuilder extends ResponseBuilder { + + public static final int STAGE_FUSION = STAGE_GET_FIELDS + 1; Review Comment: Ideally, fusion would come _before_ STAGE_GET_FIELDS so that we don't bother getting fields of docs that don't make the top-X. That's a 2x difference of doc field fetching. ########## solr/core/src/java/org/apache/solr/handler/component/CompoundResponseBuilder.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.component; + +import java.util.ArrayList; +import java.util.LinkedHashMap; +import java.util.List; +import java.util.Map; +import org.apache.solr.common.params.FacetParams; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; + +public class CompoundResponseBuilder extends ResponseBuilder { + + public static final int STAGE_FUSION = STAGE_GET_FIELDS + 1; + + public static final String RRF_PREFIX = "rrf.prefix"; + + public static class Inner extends ResponseBuilder { + private final CompoundResponseBuilder owner; + private final String my_prefix; + + public Inner(CompoundResponseBuilder owner, String my_prefix) { + super(owner.req, new SolrQueryResponse(), owner.components); + this.owner = owner; + this.my_prefix = my_prefix; + } + + @Override + protected String getParameterPrefix() { + return my_prefix; + } + + @Override + protected int getDoneStage() { + return STAGE_FUSION; + } + + @Override + public int getStage() { + return owner.getStage(); + } + + @Override + public void addRequest(SearchComponent me, ShardRequest sreq) { + // send what CompoundQueryComponent uses to detect shard requests and also make it + // something that we can use to detect only our request/response + sreq.params.set(RRF_PREFIX, my_prefix); + owner.addRequest(me, sreq); + // undo any 'facets=true' that FacetComponent.modifyRequest might have done + sreq.params.remove(FacetParams.FACET, "true"); + sreq.purpose &= ~ShardRequest.PURPOSE_GET_FACETS; Review Comment: This special case is an unfortunate wrinkle of imperfection on the simplicity of the whole approach. But it's just a couple lines. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
