ercsonusharma commented on PR #3648: URL: https://github.com/apache/solr/pull/3648#issuecomment-3310523543
Thanks for the draft @cpoerschke - appreciate it! I did a quick review. Below are my initial observations: Honestly, I couldn't understand most of this part here, as this is a draft; however, I have added a few comments. Creating a new stage in the distributed phase may create lots of complexity around other components. It makes sense when you are creating a new set of queries that have to be fired across the shards, but the ultimate goal of the phase introduced here is just to merge the results of all the shardresponse which can be done in the handleResponse method of QueryComponent without adding any additional phase. Rather, I see reusing the same stage of the distributed phase makes a lot of things easier to handle. > I imagine this approach is doing query work in parallel without any extra code? I already checked TopDocs.rrf, and it is meant for rrf on TopDocs, especially for Lucene. I find it less effort in creating something ShardDoc.rrf rather than converting the SolrDocumentList to TopcDocs and back. > I imagine this approach is doing query work in parallel without any extra code? Query work is already happening in parallel by design of the distributed process. The things that need to be parallelised is merging the docs per query post querying, which I see sequentially here as well. I'm really doubtful at this point in time as to how the faceting & highlighting would work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
