[ 
https://issues.apache.org/jira/browse/SOLR-17182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18032602#comment-18032602
 ] 

Chris M. Hostetter commented on SOLR-17182:
-------------------------------------------

I'm assuming it was intentional : )

I view the situation very analogous to this one...

In 9.5.0...
{noformat}
Improvements
---------------------
...
* SOLR-17066: SolrClient builders now allow users to specify a "default" 
collection or core
  using the `withDefaultCollection` method.  Use of the Builder methods is 
preferable to including
  the collection in the base URL accepted by certain client implementations. 
(Jason Gerlowski)
{noformat}
In 10.0.0..
{noformat}
Deprecation Removals
----------------------
...
* SOLR-17066: `SolrClient` implementations that rely on "base URL" strings now 
only accept "root" URL paths (i.e. URLs that
  end in "/solr").  Users may still specify a default collection through use of 
the `withDefaultCollection` method available
  on most SolrClient builders. (Jason Gerlowski, David Smiley, Eric Pugh)
{noformat}
 
...the "new behavior" has one entry, and the details on the "removal of the old 
behavior" has a different entry – in that case in two diff Solr versions, 
because we need to give people time to adjust their method calls, but in the 
case of a sysprop that is just going to be ignored, both can happen in the same 
release.

>From a "user looking at CHANGES" perspective: some people are only going to 
>care about deprecation removal so they know what they *have* to change, while 
>other people may want to fully review everything that changed between the 
>"old" version they are using and the "new" version they are upgrading to.

> Eliminate the need for 'solr.useExitableDirectoryReader' sysprop
> ----------------------------------------------------------------
>
>                 Key: SOLR-17182
>                 URL: https://issues.apache.org/jira/browse/SOLR-17182
>             Project: Solr
>          Issue Type: Sub-task
>          Components: Query Limits
>    Affects Versions: 9.9
>            Reporter: Chris M. Hostetter
>            Assignee: Andrzej Bialecki
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 10.0
>
>         Attachments: gen-random-csv.pl, run-queries.sh
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> As the {{QueryLimit}} functionality in Solr gets beefed up, and supports 
> multiple types of limits, it would be nice if we could find a way to 
> eliminate the need for the {{solr.useExitableDirectoryReader}} sysprop, and 
> instead just have codepaths that use the underlying IndexReader  (like 
> faceting, spellcheck, etc...)  automatically get a reader that enforces the 
> limits if/when limits are in use.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to