[
https://issues.apache.org/jira/browse/SOLR-17182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18032596#comment-18032596
]
Chris M. Hostetter commented on SOLR-17182:
-------------------------------------------
I know AB is traveling, so i can clean this up if needed -- but i thought it
was generally intentional that "Deprecation Removals" can & should have entries
in other sections if the change is bigger then a simple removal of dead code?
In this case the "Other Changes" (in behavior) is that ExitableDirectoryReader
is now used ubiquitously because it doesn't affect performance, while the
"Deprecation Removals" is that the sys prop is no longer relevant and users
shouldn't bother setting it. Both changes were made in 10.0 (unlike some other
equivalent situations where the change in behavior was rolled out _prior_ to
10.0, but the "method call" had to be left in until 10.0) because there is no
harm in users setting a sys prop that is ignored -- but the info is still
relevant in both sections.
right?
> Eliminate the need for 'solr.useExitableDirectoryReader' sysprop
> ----------------------------------------------------------------
>
> Key: SOLR-17182
> URL: https://issues.apache.org/jira/browse/SOLR-17182
> Project: Solr
> Issue Type: Sub-task
> Components: Query Limits
> Affects Versions: 9.9
> Reporter: Chris M. Hostetter
> Assignee: Andrzej Bialecki
> Priority: Major
> Labels: pull-request-available
> Fix For: 10.0
>
> Attachments: gen-random-csv.pl, run-queries.sh
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> As the {{QueryLimit}} functionality in Solr gets beefed up, and supports
> multiple types of limits, it would be nice if we could find a way to
> eliminate the need for the {{solr.useExitableDirectoryReader}} sysprop, and
> instead just have codepaths that use the underlying IndexReader (like
> faceting, spellcheck, etc...) automatically get a reader that enforces the
> limits if/when limits are in use.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
