janhoy commented on code in PR #3784:
URL: https://github.com/apache/solr/pull/3784#discussion_r2448249405


##########
solr/packaging/test/test_extraction.bats:
##########
@@ -20,6 +20,8 @@ load bats_helper
 
 setup() {
   common_clean_setup
+  # NOCOMMIT: This test must somehow start a TikaServer on random port
+  # and define a $TIKA_PORT variable

Review Comment:
   I don't want to require docker, that's why I let the tests pass with a 
comment if docker is unavailable. Perhaps we could test if docker is available 
centrally before kicking off the tests and pass in DOCKER_AVAILABLE variable 
that all the tests can simply act on?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to