epugh commented on code in PR #3784:
URL: https://github.com/apache/solr/pull/3784#discussion_r2447556249
##########
solr/packaging/test/test_extraction.bats:
##########
@@ -20,6 +20,8 @@ load bats_helper
setup() {
common_clean_setup
+ # NOCOMMIT: This test must somehow start a TikaServer on random port
+ # and define a $TIKA_PORT variable
Review Comment:
it seems like we have multiple needs for docker in our bats tests...
Between this one and the rolling file upgrade example. I wonder if we need to
just in the overall setup log a warning if Docker isnt' available. Would it
be helpful in anyway to segrate the "system" style tests that appear to lean on
Docker? Like this one? would that simplify anything? I think what you have
is good for this PR, but clearly we need to make some decisions around
testcontainers/docker/bats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
