epugh commented on code in PR #3738:
URL: https://github.com/apache/solr/pull/3738#discussion_r2409061025
##########
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##########
@@ -168,10 +168,6 @@ public static NodeConfig fromConfig(
configBuilder.setBackupRepositoryPlugins(
getBackupRepositoryPluginInfos(root.get("backup").getAll("repository")));
configBuilder.setClusterPlugins(getClusterPlugins(loader, root));
- // <metrics><hiddenSysProps></metrics> will be removed in Solr 10, but
until then, use it if a
- // <hiddenSysProps> is not provided under <solr>.
- // Remove this line in 10.0
- configBuilder.setHiddenSysProps(getHiddenSysProps(root.get("metrics")));
Review Comment:
@HoustonPutman you marked this as deprecated... Does that mean I can
remove config.setHiddenSystProps too? I *think* so.. we keep the concept
of hidden though for the redaction capablity right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
