epugh commented on code in PR #3738:
URL: https://github.com/apache/solr/pull/3738#discussion_r2416969419
##########
solr/core/src/java/org/apache/solr/core/SolrXmlConfig.java:
##########
@@ -168,10 +168,6 @@ public static NodeConfig fromConfig(
configBuilder.setBackupRepositoryPlugins(
getBackupRepositoryPluginInfos(root.get("backup").getAll("repository")));
configBuilder.setClusterPlugins(getClusterPlugins(loader, root));
- // <metrics><hiddenSysProps></metrics> will be removed in Solr 10, but
until then, use it if a
- // <hiddenSysProps> is not provided under <solr>.
- // Remove this line in 10.0
- configBuilder.setHiddenSysProps(getHiddenSysProps(root.get("metrics")));
Review Comment:
I don;t want to break this, and I'm not totally clear how far to pull the
string. I am going to back this change out... we can do it later when
@HoustonPutman is available!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
