dsmiley commented on code in PR #3772:
URL: https://github.com/apache/solr/pull/3772#discussion_r2430924251
##########
solr/solr-ref-guide/build.gradle:
##########
@@ -112,18 +112,16 @@ task buildLocalAntoraYaml {
// These variable names must use underscores, not dashes or periods
props.putAll([
["dep_version_commons_codec", libs.versions.commons.codec],
- ["dep_version_dropwizard", libs.versions.dropwizard.metrics],
["dep_version_log4j", libs.versions.apache.log4j],
["dep_version_opennlp", libs.versions.apache.opennlp],
["dep_version_tika", libs.versions.apache.tika],
["dep_version_zookeeper", libs.versions.apache.zookeeper],
- ["dep_version_lucene", libs.versions.apache.lucene],
- ["dep_version_opentelemetry", libs.versions.opentelemetry],
+ ["dep_version_opentelemetry",
libs.versions.opentelemetry.asProvider()],
].collectEntries { propKey, dependencyVersion ->
- [propKey, "${-> dependencyVersion == libs.versions.apache.lucene ?
luceneBaseVersionProvider.get() : dependencyVersion.get()}"] })
+ [propKey, "${-> dependencyVersion.get()}"] })
+ props["dep_version_lucene"] = "${ -> luceneBaseVersionProvider.get()}"
Review Comment:
I liked Lucene's special case being declared on its own line
##########
solr/solr-ref-guide/modules/configuration-guide/pages/implicit-requesthandlers.adoc:
##########
@@ -96,15 +85,6 @@ This handler must have a collection name in the path to the
endpoint.
|`solr/<collection>/admin/ping`
|{solr-javadocs}/core/org/apache/solr/handler/PingRequestHandler.html[PingRequestHandler]
|`_ADMIN_PING`
|===
-Plugins:: Return info about all registered plugins.
Review Comment:
removed; we'll ensure this removal is stated elsewhere for Solr 10
elsehwere. Found via broken link detector
##########
solr/solr-ref-guide/modules/configuration-guide/pages/implicit-requesthandlers.adoc:
##########
@@ -74,17 +74,6 @@ This handler must have a collection name in the path to the
endpoint.
|`solr/<collection>/admin/luke`
|{solr-javadocs}/core/org/apache/solr/handler/admin/LukeRequestHandler.html[LukeRequestHandler]
|`_ADMIN_LUKE`
|===
-MBeans:: Provide info about all registered
{solr-javadocs}/core/org/apache/solr/core/SolrInfoBean.html[SolrInfoMBeans].
Review Comment:
removed; we'll ensure this removal is stated elsewhere for Solr 10
elsehwere. Found via broken link detector
##########
solr/solr-ref-guide/build.gradle:
##########
@@ -112,18 +112,16 @@ task buildLocalAntoraYaml {
// These variable names must use underscores, not dashes or periods
props.putAll([
["dep_version_commons_codec", libs.versions.commons.codec],
- ["dep_version_dropwizard", libs.versions.dropwizard.metrics],
["dep_version_log4j", libs.versions.apache.log4j],
["dep_version_opennlp", libs.versions.apache.opennlp],
["dep_version_tika", libs.versions.apache.tika],
["dep_version_zookeeper", libs.versions.apache.zookeeper],
- ["dep_version_lucene", libs.versions.apache.lucene],
- ["dep_version_opentelemetry", libs.versions.opentelemetry],
+ ["dep_version_opentelemetry",
libs.versions.opentelemetry.asProvider()],
Review Comment:
Unclear why asProvider() only works there but not the others; I hoped for
consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
