janhoy commented on code in PR #3772:
URL: https://github.com/apache/solr/pull/3772#discussion_r2431387286
##########
solr/solr-ref-guide/build.gradle:
##########
@@ -112,18 +112,16 @@ task buildLocalAntoraYaml {
// These variable names must use underscores, not dashes or periods
props.putAll([
["dep_version_commons_codec", libs.versions.commons.codec],
- ["dep_version_dropwizard", libs.versions.dropwizard.metrics],
["dep_version_log4j", libs.versions.apache.log4j],
["dep_version_opennlp", libs.versions.apache.opennlp],
["dep_version_tika", libs.versions.apache.tika],
["dep_version_zookeeper", libs.versions.apache.zookeeper],
- ["dep_version_lucene", libs.versions.apache.lucene],
- ["dep_version_opentelemetry", libs.versions.opentelemetry],
+ ["dep_version_opentelemetry",
libs.versions.opentelemetry.asProvider()],
Review Comment:
Exactly, and it has worked before? Claude reasoned about a difference
between all these, namely that all but the `opentelemetry` version is prefixed
with "commons" or "apache", e.g. `apache-log4j`, so perhaps if we had
`foo-opentelemetry` we'd not need `asProvider()`? There is some code generation
going on etc. Anyway, if this solves it, good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
