epugh commented on code in PR #3740:
URL: https://github.com/apache/solr/pull/3740#discussion_r2442142560
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -690,12 +690,15 @@ public FileStore getFileStore() {
* @see #getDefaultHttpSolrClient()
* @see ZkController#getSolrClient()
* @see Http2SolrClient#requestWithBaseUrl(String, String, SolrRequest)
- * @deprecated likely to simply be moved to the ObjectCache so as to not be
used
*/
- @Deprecated
public SolrClientCache getSolrClientCache() {
Review Comment:
so `coreContainer.getDefaultHttpSolrClient().requestWithBaseUrl` already is
used in some places in DistribFileStore. However we do:
```
final var fileResponse = solrClient.requestWithBaseUrl(baseUrl, null,
fileRequest);
try (final var stream =
fileResponse.getResponseStreamIfSuccessful()) {
```
can't quite figure that getResponseStreamIfSucessful to work yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
