epugh commented on code in PR #3740:
URL: https://github.com/apache/solr/pull/3740#discussion_r2414069412
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -690,12 +690,15 @@ public FileStore getFileStore() {
* @see #getDefaultHttpSolrClient()
* @see ZkController#getSolrClient()
* @see Http2SolrClient#requestWithBaseUrl(String, String, SolrRequest)
- * @deprecated likely to simply be moved to the ObjectCache so as to not be
used
*/
- @Deprecated
public SolrClientCache getSolrClientCache() {
Review Comment:
Could you elaborate more on what the problem with this method is? Is there
a more general approach that we are supposed to take for getting clients? at
least to me, it appears super useful... If we we have a client created,
great, use it, and if not, it creates it...
Only six classes call it, so if we want to eliminate it, it doesn't seem
unsurmountable. Just unclear on what we would replace it with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
