janhoy commented on code in PR #3670: URL: https://github.com/apache/solr/pull/3670#discussion_r2430792372
########## solr/modules/extraction/src/java/org/apache/solr/handler/extraction/fromtika/BodyContentHandler.java: ########## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.extraction.fromtika; + +import java.io.OutputStream; +import java.io.Writer; +import org.apache.tika.sax.WriteOutContentHandler; +import org.apache.tika.sax.XHTMLContentHandler; +import org.apache.tika.sax.xpath.Matcher; +import org.apache.tika.sax.xpath.MatchingContentHandler; +import org.apache.tika.sax.xpath.XPathParser; Review Comment: Here are more imports depending on Tika. These classes can also be copied into our project, but it starts to get deep, with a total of 18 java source files if we want to bring it all in. <img width="247" height="485" alt="Skjermbilde 2025-10-15 kl 01 59 33" src="https://github.com/user-attachments/assets/f72270d5-4ccc-4de3-a4c1-5f62e0cd0619"; /> Seems a bit much for [ONE usage in TikaServerExtractionBackend](https://github.com/apache/solr/blob/23b2359b1e9e3449239ac76c82b2037916852a1d/solr/modules/extraction/src/java/org/apache/solr/handler/extraction/TikaServerExtractionBackend.java#L129), so I'll leave it in there and defer to later to find / write a replacement for the `BodyContentHandler`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
