janhoy commented on code in PR #3670:
URL: https://github.com/apache/solr/pull/3670#discussion_r2424991874
##########
solr/modules/extraction/src/java/org/apache/solr/handler/extraction/ExtractingDocumentLoader.java:
##########
@@ -75,40 +55,33 @@ public class ExtractingDocumentLoader extends
ContentStreamLoader {
/** Extract Only supported format. Default */
public static final String XML_FORMAT = "xml";
- /** XHTML XPath parser. */
- private static final XPathParser PARSER = new XPathParser("xhtml",
XHTMLContentHandler.XHTML);
-
final SolrCore core;
final SolrParams params;
final UpdateRequestProcessor processor;
final boolean ignoreTikaException;
- protected AutoDetectParser autoDetectParser;
+ final boolean backCompat;
private final AddUpdateCommand templateAdd;
- protected TikaConfig config;
- protected ParseContextConfig parseContextConfig;
protected SolrContentHandlerFactory factory;
+ protected ExtractionBackend backend;
public ExtractingDocumentLoader(
SolrQueryRequest req,
UpdateRequestProcessor processor,
- TikaConfig config,
- ParseContextConfig parseContextConfig,
- SolrContentHandlerFactory factory) {
+ SolrContentHandlerFactory factory,
+ ExtractionBackend backend) {
this.params = req.getParams();
this.core = req.getCore();
- this.config = config;
- this.parseContextConfig = parseContextConfig;
this.processor = processor;
+ this.backCompat = params.getBool(ExtractingParams.BACK_COMPATIBILITY,
true);
Review Comment:
I ended up sending initMap from handler to TikaExtractionBackend, and then
parse the param there, and document that this option is only settable in
config, not request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
