malliaridis commented on PR #3656: URL: https://github.com/apache/solr/pull/3656#issuecomment-3304394652
@iamsanjay I need your eyes and opinion on the changes from [last commit](https://github.com/apache/solr/pull/3656/commits/47636c7cc515f98037d7f2bc83056fe7f826cb45). As you can see there, we can simplify a lot of stuff by keeping the expanded state in the UI (ephermal state). After our discussion of removing all the `remember` references, and when I was presenting you the changes, I noticed that it may make sense for state values like this one to keep things in the UI. As mentioned before, this state is not persisted if kept in UI, but that is fine and not a problem I would say, as we do not loose anything if the state value resets (worst that can happen is the menu is closed). Since we said that we want to avoid these `remember` calls, I wanted your opinion on this change / commit, for now but also for the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
