sigram commented on code in PR #3446:
URL: https://github.com/apache/solr/pull/3446#discussion_r2244740862
##########
solr/core/src/test/org/apache/solr/search/TestQueryLimits.java:
##########
@@ -88,13 +89,12 @@ public void testQueryLimits() throws Exception {
assertNotNull(
"should have partial results for expr " + matchingExpr,
rsp.getHeader().get("partialResults"));
- if (matchingExpr.contains(".")) {
- assertEquals(matchingExpr, limit.trippedBy);
- } else {
- assertTrue(
- "expected result to start with " + matchingExpr + " but was " +
limit.trippedBy,
- limit.trippedBy.startsWith(matchingExpr));
- }
+ assertFalse("should have trippedBy info",
limit.getTrippedBy().isEmpty());
Review Comment:
That's in the next assertion, here it's just checking that it's not empty -
if it is then there's nothing to print.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
