sigram commented on code in PR #3446:
URL: https://github.com/apache/solr/pull/3446#discussion_r2244733269
##########
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java:
##########
@@ -775,7 +792,7 @@ public QueryResult search(QueryResult qr, QueryCommand cmd)
throws IOException {
protected void search(List<LeafReaderContext> leaves, Weight weight,
Collector collector)
throws IOException {
QueryLimits queryLimits = QueryLimits.getCurrentLimits();
- if (useExitableDirectoryReader || !queryLimits.isLimitsEnabled()) {
+ if (EnvUtils.getPropertyAsBool(EXITABLE_READER_PROPERTY) ||
!queryLimits.isLimitsEnabled()) {
Review Comment:
I wonder in what scenario this would happen, realistically ... and whether
we should care here. We need to make sure that the way we wrapped the original
reader uses our implementation of the QueryTimeout. We have no way to determine
that if the input is an EDR of unknown origin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
