cpoerschke commented on code in PR #3418: URL: https://github.com/apache/solr/pull/3418#discussion_r2231134571
########## solr/core/src/java/org/apache/solr/handler/component/CombinedQuerySearchHandler.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.handler.component; + +import java.util.ArrayList; +import java.util.List; +import org.apache.solr.common.params.CombinerParams; +import org.apache.solr.request.SolrQueryRequest; +import org.apache.solr.response.SolrQueryResponse; +import org.apache.solr.search.facet.FacetModule; + +/** + * The CombinedQuerySearchHandler class extends the SearchHandler and provides custom behavior for + * handling combined queries. It overrides methods to create a response builder based on the {@link + * CombinerParams#COMBINER} parameter and to define the default components included in the search + * configuration. + */ +public class CombinedQuerySearchHandler extends SearchHandler { + + /** + * Overrides the default response builder creation method. This method checks if the {@link + * CombinerParams#COMBINER} parameter is set to true in the request. If it is, it returns an + * instance of {@link CombinedQueryResponseBuilder}, otherwise, it returns an instance of {@link + * ResponseBuilder}. + * + * @param req the SolrQueryRequest object + * @param rsp the SolrQueryResponse object + * @param components the list of SearchComponent objects + * @return the appropriate ResponseBuilder instance based on the CombinerParams.COMBINER parameter + */ + @Override + protected ResponseBuilder newResponseBuilder( + SolrQueryRequest req, SolrQueryResponse rsp, List<SearchComponent> components) { + if (req.getParams().getBool(CombinerParams.COMBINER, false)) { + return new CombinedQueryResponseBuilder(req, rsp, components); + } + return new ResponseBuilder(req, rsp, components); Review Comment: minor/subjective ```suggestion return super.newResponseBuilder(req, rsp, components); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
