ercsonusharma commented on code in PR #3418:
URL: https://github.com/apache/solr/pull/3418#discussion_r2199751152
##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -1234,6 +1230,34 @@ protected void mergeIds(ResponseBuilder rb, ShardRequest
sreq) {
}
}
+ /**
+ * Creates a map of shard results based on the provided parameters.
+ *
+ * @param rb ResponseBuilder to retrieve any request info
+ * @param resultSize the desired size of the result map
+ * @param queue the queue containing sorted hits from different shards
+ * @param shardDocMap a map of shard documents indexed by shard ID
+ * @param responseDocs the final SolrDocumentList to be returned or set in
the responseBuilder
+ * @return a map of shard documents, where the keys are the shard IDs as
strings, and the values
+ * are the corresponding ShardDoc objects
+ */
+ protected Map<Object, ShardDoc> createShardResult(
Review Comment:
It should be String but the
[ResponseBuilder](https://github.com/ercsonusharma/solr/blob/9b0c76ef88a204829bbe1a2cb1cdec938d1b8586/solr/core/src/java/org/apache/solr/handler/component/ResponseBuilder.java#L169-L169)
has type Object so had to keep it Object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
