psalagnac commented on PR #3330: URL: https://github.com/apache/solr/pull/3330#issuecomment-2835958987
> How about something like [this](https://github.com/kotman12/solr/commit/aaa7564cb049bcedf5472617aac1681c3fe31c2b) to test this? I'm not a big fan of such a test as it depends too much on internals. Ideally, a test should detect regressions but should not be a blocker for evolution. I don't think adding a test is a strict requirement for this fix. I was discussing it as this feature was initially broken at the first shot, but I'm fine with skipping it if there is no easy path to write one. The shutdown sequence of Solr is very complex and unfortunately not easily testable. Please add a change log entry in 9.9, and I'll merge it this week if nothing else comes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
