psalagnac commented on PR #3330: URL: https://github.com/apache/solr/pull/3330#issuecomment-2824907741
That's a great analysis. Thanks @mlbiscoc and @kotman12. > Didn't think a test was necessary for this, but we're happy to add one if the community feels it's warranted That's very unfortunate that a broken feature was initially merged. The very complex shutdown sequence somehow led to this broken change. Adding a test would make sure there is no future regression. Saying this, I have no idea how hard it would be to test this. Having a test is not a requirement but a nice to have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
