dsmiley commented on code in PR #3204:
URL: https://github.com/apache/solr/pull/3204#discussion_r1966904872
##########
solr/core/src/java/org/apache/solr/handler/admin/SystemInfoHandler.java:
##########
@@ -145,7 +145,7 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
rsp.add("zkHost",
getCoreContainer(req).getZkController().getZkServerAddress());
}
if (cc != null) {
- rsp.add("solr_home", cc.getSolrHome());
+ rsp.add("solr_home", cc.getSolrHome().toString());
Review Comment:
Good eye! I agree with removing toString here. Whether toAbsolutePath
should be called or not is another question from this PR; I'm ambivalent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
