renatoh commented on code in PR #3163: URL: https://github.com/apache/solr/pull/3163#discussion_r1947968424
########## solr/solrj/src/test/org/apache/solr/common/util/TestJavaBinCodec.java: ########## @@ -293,7 +306,7 @@ public void testForwardCompat() throws IOException { for (int i = 1; i < currentFormatBytes.length; i++) { // ignore the first byte. It is version information - assertEquals(newFormatBytes[i], currentFormatBytes[i]); + assertEquals("for i:" + i, newFormatBytes[i], currentFormatBytes[i]); Review Comment: > ClusterStateProviderTest: looks like just needs to convert both maps to the same type (e.g. wrap in HashMap Where would I do that? There is really a lot happening in those tests and I still have not managed to fully wrap my head around it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org