renatoh commented on code in PR #3163:
URL: https://github.com/apache/solr/pull/3163#discussion_r1947912506
##########
solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java:
##########
@@ -863,6 +871,21 @@ protected Map<Object, Object> readMap(DataInputInputStream
dis, int sz) throws I
return m;
}
+ @SuppressWarnings({"rawtypes", "unchecked"})
+ protected Map<?, Object>
readMapAsSimpleOrderedMapForStringKeys(DataInputInputStream dis, int sz)
+ throws IOException {
+
+ SimpleOrderedMap<Object> entries = new SimpleOrderedMap<>(sz);
+
+ for (int i = 0; i < sz; i++) {
+ Object key = readVal(dis);
+ assert key instanceof String;
+ Object val = readVal(dis);
+ entries.put((String) key, val);
Review Comment:
oh, I am glad at least one of us knows what we are doing here;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
