dsmiley commented on PR #2932: URL: https://github.com/apache/solr/pull/2932#issuecomment-2573565263
Adding an additional HashMap inside SimpleOrderedMap misses the point of why NamedList exists. It's for something super lean/fast that's only for transferring stuff (i.e. to be serialized), navigated by iteration once. For that use-case, a hashCode system is a waste. But Solr uses it for configuration as well, a questionable choice that's not in line with NamedList's advantages. Perhaps a radical point of view is that NamedList shouldn't even have "get" methods, leaving only iteration, thus emphasizing its purpose. For sure, Solr over-uses NamedList. And it's [hard to stop using it](https://github.com/apache/solr/pull/2916#pullrequestreview-2518454057) because of SolrJ "javabin" compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
