renatoh commented on PR #2932: URL: https://github.com/apache/solr/pull/2932#issuecomment-2569586983
I've investigated why the tests are now failing. The issue is that the method org.apache.solr.request.SimpleFacets#getFacetFieldCounts is now returning an empty NamedList, and not its subtype SimpleOrderedMap anymore. This seems fine since the return type of that method is NamedList. The problem is that returning NamedList causes that in the response-json, the facet_counts/facet_fields will become a list:  The method org.apache.solr.common.util.JsonTextWriter#writeNamedList distinguish between these types and writes a different data structure. I think the root cause is the method org.apache.solr.request.SimpleFacets#getFacetFieldCounts allowing to return the super-type NamedList. Shall I change the return type of that method to SimpleOrderedMap? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
