dsmiley commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1857209488
########## solr/modules/monitor/src/java/org/apache/solr/monitor/search/ParallelSolrMatcherSink.java: ########## @@ -0,0 +1,95 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) under one or more + * * contributor license agreements. See the NOTICE file distributed with + * * this work for additional information regarding copyright ownership. + * * The ASF licenses this file to You under the Apache License, Version 2.0 + * * (the "License"); you may not use this file except in compliance with + * * the License. You may obtain a copy of the License at + * * + * * http://www.apache.org/licenses/LICENSE-2.0 + * * + * * Unless required by applicable law or agreed to in writing, software + * * distributed under the License is distributed on an "AS IS" BASIS, + * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * * See the License for the specific language governing permissions and + * * limitations under the License. + * + */ + +package org.apache.solr.monitor.search; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletionService; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.ExecutorCompletionService; +import java.util.concurrent.ExecutorService; +import java.util.function.Consumer; +import java.util.function.Function; +import org.apache.lucene.monitor.CandidateMatcher; +import org.apache.lucene.monitor.MatchesAggregator; +import org.apache.lucene.monitor.MultiMatchingQueries; +import org.apache.lucene.monitor.QueryMatch; +import org.apache.lucene.search.IndexSearcher; +import org.apache.lucene.search.Query; + +class ParallelSolrMatcherSink<T extends QueryMatch> implements SolrMatcherSink { Review Comment: Yes please do a `TwoPhaseIterator`. It's nice to see contributors like you come along that know of such Lucene low level depths :-) . `PostFilter` should be a choice of last resort; it pre-dated TwoPhaseIterator. I fought to reduce where PostFilter is used in Solr; and it's finally at the point where it's used where it must be used, except FunctionRangeQuery [SOLR-14164](https://issues.apache.org/jira/browse/SOLR-14164) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
