kotman12 commented on code in PR #2382: URL: https://github.com/apache/solr/pull/2382#discussion_r1855342761
########## solr/modules/monitor/src/java/org/apache/solr/monitor/search/ParallelSolrMatcherSink.java: ########## @@ -0,0 +1,95 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) under one or more + * * contributor license agreements. See the NOTICE file distributed with + * * this work for additional information regarding copyright ownership. + * * The ASF licenses this file to You under the Apache License, Version 2.0 + * * (the "License"); you may not use this file except in compliance with + * * the License. You may obtain a copy of the License at + * * + * * http://www.apache.org/licenses/LICENSE-2.0 + * * + * * Unless required by applicable law or agreed to in writing, software + * * distributed under the License is distributed on an "AS IS" BASIS, + * * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * * See the License for the specific language governing permissions and + * * limitations under the License. + * + */ + +package org.apache.solr.monitor.search; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.CompletionService; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.ExecutorCompletionService; +import java.util.concurrent.ExecutorService; +import java.util.function.Consumer; +import java.util.function.Function; +import org.apache.lucene.monitor.CandidateMatcher; +import org.apache.lucene.monitor.MatchesAggregator; +import org.apache.lucene.monitor.MultiMatchingQueries; +import org.apache.lucene.monitor.QueryMatch; +import org.apache.lucene.search.IndexSearcher; +import org.apache.lucene.search.Query; + +class ParallelSolrMatcherSink<T extends QueryMatch> implements SolrMatcherSink { Review Comment: @cpoerschke after pulling latest upstream and playing around with `multiThreaded` I discovered that the multi-threaded searcher is explicitly skipped for any query that includes a post filter. As such, the current implementation won't easily benefit from this feature. I am considering refactoring this to be a custom query with a two-phase iterator instead. Another motivation for this would be to take advantage of the latest _intra_-segment parallelization work done in lucene. I might create a branch to explore this idea.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
