cugarte commented on PR #2788: URL: https://github.com/apache/solr/pull/2788#issuecomment-2452580384
Just saw your changes to `solr/solrj/src/resources/java-template/api.mustache` in https://github.com/apache/solr/pull/1993/files#diff-d053f95e7416908019cf4f7f5e8ede80cc24e3ed8eed2a72d078b75406251c8c . I applied the same change, which fixed Problem 2 I noted above. The most recent commit makes that change, updates a unit test accordingly and nukes the unnecessary model. I gather the correct changes to `api.mustache` would make the generated code throw an exception in the right case (Problem 1 above). Will see if I can come up with something that works. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
