malliaridis commented on code in PR #2816: URL: https://github.com/apache/solr/pull/2816#discussion_r1821171372
########## solr/bin/solr.cmd: ########## @@ -263,7 +263,6 @@ IF "%1"=="assert" goto run_solrcli IF "%1"=="zk" goto run_solrcli Review Comment: I am looking into this right now. We have a lot of repetitive code in `bin/solr.cmd` that can be optimized if code blocks are rearranged. The way `bin/solr` is handling the special commands is probably the approach we gonna follow on the windows script as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
