epugh commented on code in PR #2816: URL: https://github.com/apache/solr/pull/2816#discussion_r1821125410
########## solr/bin/solr.cmd: ########## @@ -263,7 +263,6 @@ IF "%1"=="assert" goto run_solrcli IF "%1"=="zk" goto run_solrcli Review Comment: Maybe for another jira, but the way `bin/solr` works is that all the commands go thorugh a check for if you are special.. For example, here is the auth check: https://github.com/apache/solr/blob/main/solr/bin/solr#L594 and then if you aren't start/stop/restart, you get the `run_solrcli` treatment: https://github.com/apache/solr/blob/main/solr/bin/solr#L629. This removed a bunch of lines! ########## solr/bin/solr.cmd: ########## @@ -1207,244 +1206,7 @@ SHIFT SHIFT goto parse_config_args -REM Clumsy to do the state machine thing for -d and -n, but that's required for back-compat Review Comment: wow! that's awesome! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
