dsmiley commented on PR #2682: URL: https://github.com/apache/solr/pull/2682#issuecomment-2420572657
No please don't create yet another PR just because the diff isn't looking clear. I've already reviewed everything so I recommend a rebase & force push. You're super close to merging this. * remove `UseConcMarkSweepGC` that is obsolete * CHANGES.txt add an entry for Solr 10 "Other Changes" * `major-changes-in-solr-10.adoc` should be updated. Add a Misc section maybe? And in the SolrJ section, add a bullet for Java 17 dependency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
