dsmiley commented on PR #2682: URL: https://github.com/apache/solr/pull/2682#issuecomment-2419997783
Sadly the PR diff is now confusing; seems to have dependency updates and stuff from main but GitHub isn't detecting/realizing that this PR shouldn't be bringing such changes if merged. Or you inadvertently did stuff here? Security Manager: decouple from this PR; a dev list thread if we want to explore disabling by default or options to suppress this. Jenkins: Yes, I'll updated some but didn't update all. Hopefully you can continue that; I find myself too busy. You didn't update bin/solr options yet but you plan to remove at least one obsolete option. Further JDK tuning can be a new dev list thread. > Whenever we plan to merge it, we need to make the Java version change on CI servers. I wonder Do we even need that new file which we added for crave; instead, we can change Java version on crave as well. CC @uvatbc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
