dsmiley commented on code in PR #2741:
URL: https://github.com/apache/solr/pull/2741#discussion_r1794523415
##########
solr/core/src/java/org/apache/solr/cloud/Overseer.java:
##########
@@ -857,13 +857,18 @@ private void doCompatCheck(BiConsumer<String, Object>
consumer) {
return;
}
- try (CloudSolrClient client =
- new CloudHttp2SolrClient.Builder(
-
Collections.singletonList(getZkController().getZkServerAddress()),
Optional.empty())
- .withZkClientTimeout(30000, TimeUnit.MILLISECONDS)
- .withZkConnectTimeout(15000, TimeUnit.MILLISECONDS)
- .withHttpClient(getCoreContainer().getDefaultHttpSolrClient())
- .build()) {
+ try (var solrClient =
Review Comment:
since this client is embedded into the Cloud one, I think you should name
this var maybe internalClient or something and don't refer to it in the block
of code for the try-finally except for passing into the CloudSolrClient.
BTW; it really is painful to customize these particular timeouts as we're
forced to do it at an inner layer. Ugh. @epugh not sure if you worked on some
of the SolrClient building methods and saw this issue before. Maybe we should
add the same methods to the CloudHttp2SolrClient.Builder
##########
solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java:
##########
@@ -192,7 +192,7 @@ private boolean fetchFileFromNodeAndPersist(String
fromNode) {
try {
GenericSolrRequest request = new GenericSolrRequest(GET, "/node/files"
+ getMetaPath());
request.setResponseParser(new InputStreamResponseParser(null));
- var response = solrClient.requestWithBaseUrl(baseUrl, client ->
client.request(request));
+ var response = solrClient.requestWithBaseUrl(baseUrl,
request::process).getResponse();
Review Comment:
This is rather nice. @gerlowskija, I think we can do away with the
lambda-less requestWithBaseUrl I was suggesting. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
