dsmiley commented on code in PR #2751: URL: https://github.com/apache/solr/pull/2751#discussion_r1794483683
########## solr/core/src/java/org/apache/solr/cloud/ZkController.java: ########## @@ -768,7 +768,7 @@ public void close() { } finally { sysPropsCacher.close(); - customThreadPool.execute(() -> IOUtils.closeQuietly(cloudSolrClient)); Review Comment: I think it was named well before. The suffix should reflect the type -- a "SolrClient" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org