iamsanjay commented on code in PR #2665:
URL: https://github.com/apache/solr/pull/2665#discussion_r1734093838


##########
gradle/testing/defaults-tests.gradle:
##########
@@ -181,6 +181,13 @@ allprojects {
         // Print some diagnostics about locations used.
         logger.info("Test folders for {}: cwd={}, tmp={}", project.path, 
testsCwd, testsTmpDir)
       }
+      if(isCIBuild) {
+        retry {
+          maxRetries = 20
+          maxFailures = 20

Review Comment:
   You're correct. The maxRetries setting applies to each round, and if the 
total failures in that round exceed the limit, no retries are attempted. I 
retested with multiple tests, and this confirmed it, clearing up any doubts. I 
think 10 is perfect then!



##########
gradle/testing/defaults-tests.gradle:
##########
@@ -181,6 +181,13 @@ allprojects {
         // Print some diagnostics about locations used.
         logger.info("Test folders for {}: cwd={}, tmp={}", project.path, 
testsCwd, testsTmpDir)
       }
+      if(isCIBuild) {
+        retry {
+          maxRetries = 20
+          maxFailures = 20

Review Comment:
   I will add the link of github repo.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to