dsmiley commented on code in PR #2665:
URL: https://github.com/apache/solr/pull/2665#discussion_r1733589772
##########
gradle/testing/defaults-tests.gradle:
##########
@@ -181,6 +181,13 @@ allprojects {
// Print some diagnostics about locations used.
logger.info("Test folders for {}: cwd={}, tmp={}", project.path,
testsCwd, testsTmpDir)
}
+ if(isCIBuild) {
+ retry {
+ maxRetries = 20
+ maxFailures = 20
Review Comment:
I read the docs on these two.
maxFailures -- maybe 10 instead? If there are 11 failures or more, I'd
think something is broadly wrong and we shouldn't do retries.
maxRetries -- 20 seems like a lot; do we really want to rerun a test as many
as 20 times? I'd say 5 is plenty.
##########
gradle/testing/defaults-tests.gradle:
##########
@@ -181,6 +181,13 @@ allprojects {
// Print some diagnostics about locations used.
logger.info("Test folders for {}: cwd={}, tmp={}", project.path,
testsCwd, testsTmpDir)
}
+ if(isCIBuild) {
Review Comment:
We have yet to apply the Google Java Style format to build files (we should
do this for Solr 10!) but please try to adhere to it.
```suggestion
if (isCIBuild) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
