sigram commented on code in PR #2666:
URL: https://github.com/apache/solr/pull/2666#discussion_r1732394489


##########
solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-9.adoc:
##########
@@ -71,6 +71,13 @@ Due to changes in Lucene 9, that isn't possible any more.
 === Configuration
 In solrconfig.xml, the `numVersionBuckets` and `versionBucketLockTimeoutMs` 
settings are now obsolete and ignored; a warning will be logged if specified.
 
+=== Partial Results
+When solr is used for reporting, legal discovery or other use cases that 
cannot accept partial results, yet it still needs to be protected from 
long-running queries, users may now opt out of receiving partial results.
+This feature should eliminate some wasted processing and bandwidth, as well as 
simplifying client side logic, and reducing the chance of inappropriate 
responses to the user.
+This can be enabled either via a request parameter (`allowPartialResults`), 
environment variable or system property.
+The partialResults attribute in the request header will now have three 
possible states: `"true"`, `"omitted"` or absent, with the new `"omitted"` 
value indicating the difference between a timed out request with results 
omitted due to query limits and results that are merely empty because the query 
didn't match any docs.

Review Comment:
   Hmm, maybe using "discarded" instead of "omitted", both in the docs AND in 
the response header, would make it clearer?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to