gus-asf commented on PR #2666: URL: https://github.com/apache/solr/pull/2666#issuecomment-2310297839
looking back at https://github.com/apache/solr/pull/2493 I'm exploring if there are ways to also shorten the case where partial results are desired, but possibly due to super short CpuTimeAllowed in some tests, I'm occasionally (but not consistently) hitting cases where response builder hasn't done any work yet so various bits (such as requestIds) are null or otherwise uninitialized when we get to handleRequestBody. Exactly why is unclear, but some bits of responsebuilder maybe should be initialized by default. (i.e requestIds can be set to Collections.emptyMap() initially, since dozens of places don't check it for null) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
