dsmiley commented on PR #2598: URL: https://github.com/apache/solr/pull/2598#issuecomment-2256293762
> In that case maybe the thing to do here isn't to delete the conditional outright but to tweak it so that it sets the same default (i.e. MockDirectoryFactory) as the configs Actually, let's simply delete this; one less potential moving part / layer for where this might be set. It _should_ be enough to ensure all our test configs refer to MockDirectoryFactory. I suppose there's a case for RAMDirectoryFactory, which is performance (faster running tests; less disk thrashing). Albeit some tests need persistence, obviously. But I'm unsure how to balance that with MockDirectoryFactory. The safe bet is certainly MockDirectoryFactory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
