gerlowskija opened a new pull request, #2598:
URL: https://github.com/apache/solr/pull/2598
# Description
IDE's like IntelliJ and Eclipse have internal test-runners that can often
run tests faster than using the project's gradle build. But many tests cannot
use these IDE-internal runners because they rely on values set by the gradle
build (particularly system properties set in 'randomization.gradle').
The primary offender here is the directory factory setting, which is set as
RAMDirectoryFactory in test configs, but is then overridden by
randomization.gradle to be 'MockDirectoryFactory' instead.
# Solution
This commit pushes the randomization.gradle override into individual
test-config files, so that tests will see the same "effective default"
regardless of whether they're run by an IDE's runner or using the gradle build.
# Tests
N/A - existing tests continue to pass
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to
Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my
code conforms to the standards described there to the best of my ability.
- [x] I have given Solr maintainers
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
